RegisterNetworkErrorListener should fire when there's an error connecting to the peer #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onnecting to the peer
Put network error in request manager to cover more cases
Resolve discripencies with new and old notification interfaces
hannahhoward
force-pushed
the
fix/req-err-handler
branch
from
31e5ea6
to
d063643
Compare
hannahhoward
approved these changes
Dec 11, 2020
This was referenced Dec 16, 2020
marten-seemann
pushed a commit
that referenced
this pull request
Mar 2, 2023
* feat: latest go-graphsync * feat: auto-restart connection for push data channels * refactor: simplify push channel monitor config * fix: more granular interval checking of data rates * refactor: simplify push channel monitor naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #124
This PR adds a test case, and a WIP implementation.
@hannahhoward I'm not sure if the implementation follows the pattern for how these cases are normally handled to feel free to change.